Skip to content

Let a pseudo-class be followed by a quoted attribute selector - #180

Merged
jdalton merged 1 commit into
dperini:masterfrom
jdalton:fix/attribute-after-pseudo
Sep 6, 2026
Merged

Let a pseudo-class be followed by a quoted attribute selector#180
jdalton merged 1 commit into
dperini:masterfrom
jdalton:fix/attribute-after-pseudo

Conversation

@jdalton

@jdalton jdalton commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Fix

Preserve quoted attribute selectors after pseudo-classes and combinators. Invalid-selector errors retain the normalized selector text instead of comma-joined parser fragments.

Tests

Seven focused regressions cover both quote styles, child and sibling combinators, matching and selection, cached queries, DOM changes, and error text. The full local CI workflow passes, including Node tests, package compatibility, WPT on both builds, and coverage thresholds.

Closes #175.

@jdalton
jdalton force-pushed the fix/attribute-after-pseudo branch from 8437dbc to d590b98 Compare September 4, 2026 18:00
@jdalton jdalton mentioned this pull request Sep 5, 2026
Closed
@jdalton
jdalton force-pushed the fix/attribute-after-pseudo branch from d590b98 to 3eee6f7 Compare September 5, 2026 02:47
@jdalton

jdalton commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator Author

This one sits with #179 and #181, which touch the parser and pattern fixes.

They do not depend on each other. All seventeen in the series cherry-pick onto master in any order, and I checked that in both directions, so any one of these can land alone. The order below is the one they read best in:

  • #179 fixes the forgiving fallback and the EOF-terminated argument.
  • #180 lets a pseudo-class be followed by a quoted attribute selector.
  • #181 anchors the alternation in the :link and :placeholder-shown tests.

This was referenced Sep 5, 2026
Merged
Merged
Merged
@jdalton jdalton added the bug label Sep 5, 2026
@jdalton
jdalton force-pushed the fix/attribute-after-pseudo branch from 3eee6f7 to 1763320 Compare September 6, 2026 02:30
@jdalton
jdalton force-pushed the fix/attribute-after-pseudo branch from 1763320 to 7ea402f Compare September 6, 2026 04:36
@jdalton
jdalton merged commit e924ab6 into dperini:master Sep 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Parse error: [attr i] flag + pseudo-class followed by quoted attribute selector

1 participant

@jdalton